Change in ovirt-engine[ovirt-engine-3.3]: webadmin: cannot import VM with snapshots without collapsing...

iheim at redhat.com iheim at redhat.com
Sun Nov 10 07:48:40 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: webadmin: cannot import VM with snapshots without collapsing them
......................................................................


webadmin: cannot import VM with snapshots without collapsing them

When importing a VM each disk of the VM is verified if it's parent is present
on a template in the system. If not, the snapshots has to be collapsed.

The problem was that if the VM had snapshots the disks returned in
getDiskMap() returned the snapshots (instead of the root disks).

Fixed by finding the root disks and the verification is done according to them.

Change-Id: Ib177757b64090bc5066acc3d89766bb0dbc29385
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1020830
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
1 file changed, 31 insertions(+), 5 deletions(-)

Approvals:
  Tomas Jelinek: Verified
  Daniel Erez: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21062
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib177757b64090bc5066acc3d89766bb0dbc29385
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list