Change in ovirt-engine[master]: core: move network validations on run vm to RunVmValidator

ofrenkel at redhat.com ofrenkel at redhat.com
Wed Nov 13 08:00:59 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: move network validations on run vm to RunVmValidator
......................................................................


core: move network validations on run vm to RunVmValidator

Move the network validations from RunVmCommand to RunVmValidator, where
this kind of validations should reside. The methods that were moved were
changed to return ValidationResult instead of boolean to conform the
standard.

Change-Id: I6aff70b45617e90deac826f2a873c1604c9a4241
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
3 files changed, 103 insertions(+), 88 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17971
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6aff70b45617e90deac826f2a873c1604c9a4241
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list