Change in ovirt-engine[master]: core: increase AutoStartVmsRunner job frequency

ofrenkel at redhat.com ofrenkel at redhat.com
Thu Nov 14 15:24:39 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: increase AutoStartVmsRunner job frequency
......................................................................


core: increase AutoStartVmsRunner job frequency

This patch changes the default frequency of the AutoStartVmsRunner from
60 sec to 1 sec. Instead of invoking the RunVmCommand on each iteration,
the AutoStartVmsRunner now try to acquire the needed VM lock first, and
only if it succeed it invokes the RunVmCommand and the command release
the acquired lock.

The type of the internal collection of HA VMs to run in
AutoStartVmsRunner job is also changed to CopyOnWriteArraySet which is a
more appropriate data structure for this use-case and for the following
planned enhancements.

Change-Id: I0968cae554458f53a1f30643848bb8d88bd4de11
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
7 files changed, 88 insertions(+), 30 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19499
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0968cae554458f53a1f30643848bb8d88bd4de11
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list