Change in ovirt-engine[master]: core: minor refactoring in RunVmValidator

ofrenkel at redhat.com ofrenkel at redhat.com
Mon Nov 18 16:19:36 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: minor refactoring in RunVmValidator
......................................................................


core: minor refactoring in RunVmValidator

- rename methods which are validating network related stuff to being
  with 'validate'
- moved CanRunVm to the top of the class
- organized the class methods order such that the validation methods
  would be grouped together and the utility method be in the buttom

Change-Id: I80ac05cb4028578364ef710603a674834a33a1a2
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
1 file changed, 185 insertions(+), 178 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18240
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I80ac05cb4028578364ef710603a674834a33a1a2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list