Change in ovirt-engine[master]: engine: cleanup AddVdsCommand locking

kmayilsa at redhat.com kmayilsa at redhat.com
Thu Nov 21 06:15:52 UTC 2013


Kanagaraj M has submitted this change and it was merged.

Change subject: engine: cleanup AddVdsCommand locking
......................................................................


engine: cleanup AddVdsCommand locking

AddVdsCommand was overriding getExclusiveLocks
to lock the cluster if cluster supports gluster service.

But this is not required here as the "gluster peer probe"
which requires the lock only happens after the host comes
up.

Removed the code which does a "gluster peer probe" in
case ConfigValues.InstallVds = true. This code gets
executed as InitVdsOnUpCommand and is not required
here.

Change-Id: I6189d7f0046a943a58db9d6734c92fe462c9db52
Bug-Url: https://bugzilla.redhat.com/998799
Signed-off-by: Sahina Bose <sabose at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
1 file changed, 2 insertions(+), 50 deletions(-)

Approvals:
  Kanagaraj M: Looks good to me, approved
  Sahina Bose: Verified



-- 
To view, visit http://gerrit.ovirt.org/18350
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6189d7f0046a943a58db9d6734c92fe462c9db52
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list