Change in ovirt-engine[master]: engine : User is not able to see newly added permissions on ...

emesika at redhat.com emesika at redhat.com
Sun Nov 24 07:22:47 UTC 2013


Eli Mesika has submitted this change and it was merged.

Change subject: engine : User is not able to see newly added permissions on object if he inherited this permission on that object
......................................................................


engine : User is not able to see newly added permissions on object if he inherited this permission on that object

In UserPortal if user inherit some permissions on some object,
than if he try to add new permissions to object that he inherit
permission from, he is not able to see this newly added permissions.

>From webadmin portal getAllUsersWithPermission returns
false so the original query "GetPermissionsByEntityId"
is executed.

>From USer portal getAllUsersWithPermission returns true
so the new query "GetAllUsersWithPermissionsOnEntityByEntityId"
is executed.

Change-Id: I9f8f8b110c41665bb6efe2647b654b845d70b7de
Bug-Url: https://bugzilla.redhat.com/877906
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionsForObjectQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetPermissionsForObjectQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetPermissionsForObjectParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/PermissionDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/UserPortalPermissionListModel.java
M packaging/dbscripts/multi_level_administration_sp.sql
11 files changed, 100 insertions(+), 7 deletions(-)

Approvals:
  Eli Mesika: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19377
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9f8f8b110c41665bb6efe2647b654b845d70b7de
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list