Change in ovirt-engine[master]: core: fetch disks internally in RunVmValidator

ofrenkel at redhat.com ofrenkel at redhat.com
Sun Nov 24 11:31:11 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: fetch disks internally in RunVmValidator
......................................................................


core: fetch disks internally in RunVmValidator

RunVmValidator was used to get the disks of the VM which is going to be
run from outside, as a parameter of the canRunVm method. This patch
changes this, such that the disks are no longer passed from outside,
they are now fetched internally.

Change-Id: I0c06577a1fab8c3c912f91a78a4303f83c8edcc0
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
4 files changed, 19 insertions(+), 13 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18241
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0c06577a1fab8c3c912f91a78a4303f83c8edcc0
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list