Change in ovirt-engine[master]: webadmin: Dont replace . with _ if error not in resources

kmayilsa at redhat.com kmayilsa at redhat.com
Mon Nov 25 06:02:41 UTC 2013


Kanagaraj M has submitted this change and it was merged.

Change subject: webadmin: Dont replace . with _ if error not in resources
......................................................................


webadmin: Dont replace . with _ if error not in resources

Modified to not to replace . with _ if the error message is NOT found in the
resources.
This was causing an issue if an error does not exist in resources, and
contains full stops or valid "." (e.g. IP Address / FQDN). All of the
"." were getting replaced with _ if the error message shown on the
screen.

Change-Id: I68c8354c7fec9e8a85fbea47bd7e4586f49defdf
Bug-Url: https://bugzilla.redhat.com/1024184
Signed-off-by: Shubhendu Tripathi <shtripat at redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/ErrorTranslator.java
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Shubhendu Tripathi: Verified
  Kanagaraj M: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21083
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I68c8354c7fec9e8a85fbea47bd7e4586f49defdf
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list