Change in ovirt-engine[master]: engine: don't iterate map with keyset in LinkHelper

tnisan at redhat.com tnisan at redhat.com
Mon Nov 25 13:54:12 UTC 2013


Tal Nisan has submitted this change and it was merged.

Change subject: engine: don't iterate map with keyset in LinkHelper
......................................................................


engine: don't iterate map with keyset in LinkHelper

Iterate map with entryset for more efficient iteration.
Solves findbug warning of type WMI_WRONG_MAP_ITERATOR

Change-Id: I62da8696f89f111b6a3872f02ec8a6dd1663fc34
Signed-off-by: Alissa Bonas <abonas at redhat.com>
---
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21613
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I62da8696f89f111b6a3872f02ec8a6dd1663fc34
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list