Change in ovirt-engine[master]: engine: [cleanup] Rename RunPublicQuery to runPublicQuery

tnisan at redhat.com tnisan at redhat.com
Thu Nov 28 09:09:26 UTC 2013


Tal Nisan has submitted this change and it was merged.

Change subject: engine: [cleanup] Rename RunPublicQuery to runPublicQuery
......................................................................


engine: [cleanup] Rename RunPublicQuery to runPublicQuery

Findbugs warning message:
Backend.java:598, NM_METHOD_NAMING_CONVENTION, Priority: Low

The method name
org.ovirt.engine.core.bll.Backend.RunPublicQuery(VdcQueryType,
                                                 VdcQueryParametersBase)
doesn't start with a lower case letter

Methods should be verbs, in mixed case with the first letter lowercase,
with the first letter of each internal word capitalized.

Change-Id: If105d68de5ad76d61a9123efac5c14440a8a3032
Signed-off-by: Adam Litke <alitke at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/BackendLocal.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/security/auth/LoginValidatorTest.java
M backend/manager/modules/welcome/src/main/java/org/ovirt/engine/core/WelcomeServlet.java
M backend/manager/modules/welcome/src/test/java/org/ovirt/engine/core/WelcomeServletTest.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GwtDynamicHostPageServlet.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/AbstractGwtDynamicHostPageServletTest.java
9 files changed, 13 insertions(+), 13 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/21548
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If105d68de5ad76d61a9123efac5c14440a8a3032
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list