Change in ovirt-engine[ovirt-engine-3.3]: frontend: Allow using any domain for sysprep

iheim at redhat.com iheim at redhat.com
Fri Oct 4 06:27:40 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: frontend: Allow using any domain for sysprep
......................................................................


frontend: Allow using any domain for sysprep

This patch allows user to alter domain name for sysprep when running the
machine using "run once".

The problem was caused by wrong condition when filling from model to
RunVmOnceParams. Fixed by adjusting the condition.

There was also another issue with the ComboBox, which wasn't working
correctly when there is a custom text put in and user wants to apply a
value from the drop-down menu. In this case the value is not updated.
Hot-fixed by manual handling of DOM events.

Change-Id: Iff87239de98694cf124a44e7cb39f6d9e867ce93
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1015154
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmRunOncePopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/RunOnceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalRunOnceModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WebadminRunOnceModel.java
4 files changed, 47 insertions(+), 59 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19846
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iff87239de98694cf124a44e7cb39f6d9e867ce93
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list