Change in ovirt-engine[master]: webadmin: Display size of ISO and floppy files in human read...

derez at redhat.com derez at redhat.com
Mon Oct 7 12:43:57 UTC 2013


Daniel Erez has submitted this change and it was merged.

Change subject: webadmin: Display size of ISO and floppy files in human readable format
......................................................................


webadmin: Display size of ISO and floppy files in human readable format

Up until now DiskSizeRenderer which is used to render image/disk/file
sizes had 2 limitations:
1. Size appeared only in GB.
2. Size smaller than 1GB appeared as '<1GB'

>From now on, it also supports widely adopted Human Readable Format.

This patch uses new capability when rendering size of ISO files and
floppies under Storage ->ISO Storage Domain -> Images.

Change-Id: I95961fde2256a44b8474d8f41562bc0e33b0ad4a
Bug-Url: https://bugzilla.redhat.com/1005889
Signed-off-by: Sergey Gotliv <sgotliv at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/DiskSizeRenderer.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskSizeColumn.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/storage/SubTabStorageIsoView.java
3 files changed, 48 insertions(+), 4 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19550
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I95961fde2256a44b8474d8f41562bc0e33b0ad4a
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list