Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Allowed non-draggable NetworkItemPanel

iheim at redhat.com iheim at redhat.com
Tue Oct 8 13:46:30 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: webadmin: Allowed non-draggable NetworkItemPanel
......................................................................


webadmin: Allowed non-draggable NetworkItemPanel

It seems that so far setting draggable to false did nothing, the item
would still be draggable; for some reason calling
setDraggable(Element.DRAGGABLE_FALSE) adds the draggable property to
an element and sets it to true!

Added some code to disable the "draggable skin" and the actual drag
operation when an item has been constructed as non-draggable. Also,
changed bonds to be draggable explicitly, as they have been draggable
all this time and I've heard no complaints.

Change-Id: I0f130803ce2403cc26297ec8d06ef62d23837b96
Bug-Url: https://bugzilla.redhat.com/990612
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/BondPanel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
2 files changed, 20 insertions(+), 17 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19821
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f130803ce2403cc26297ec8d06ef62d23837b96
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list