Change in ovirt-engine[ovirt-engine-3.3]: webadmin: update search string on bookmark selection

iheim at redhat.com iheim at redhat.com
Tue Oct 8 13:50:49 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: webadmin: update search string on bookmark selection
......................................................................


webadmin: update search string on bookmark selection

After editing a bookmark name, that bookmark wasn't being properly cleared
of its selection. The UI component was no longer selected, but the model
thought it was still selected. So re-clicking that bookmark had no effect.

Fixed by properly clearing the bookmark selection on bookmark save.

Change-Id: Ic9763ab32eb3fcef7375553e7b9e264899583a1d
Bug-Url: https://bugzilla.redhat.com/996611
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/bookmarks/BookmarkListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/model/BookmarkModelProvider.java
2 files changed, 28 insertions(+), 0 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19812
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9763ab32eb3fcef7375553e7b9e264899583a1d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list