Change in ovirt-engine[master]: core: LocalAdminPassword exception after engine restart

yzaslavs at redhat.com yzaslavs at redhat.com
Wed Oct 9 13:28:35 UTC 2013


Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: LocalAdminPassword exception after engine restart
......................................................................


core: LocalAdminPassword exception after engine restart

After oVirt host comes up from reboot, we see
javax.crypto.BadPaddingException: Data must start with zero
exception in engine.log:

When GetConfigurationValuesQuery is executed it
retrives the values for all the versions and returns
it. But LOCAL_ADMIN_PASSWD exists only for version
general which breaks the logic in DbConfigUtils.

This patch introduces a black list of
all passwd fields that have values only
for version "general". So the backend does
not try to extract values for other versions
for these ConfigurationValues

Change-Id: I000bbb3cf5a6d1d636c49247e85858b02b2f358a
Bug-Url: https://bugzilla.redhat.com/994454
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValuesQuery.java
1 file changed, 22 insertions(+), 6 deletions(-)

Approvals:
  Ravi Nori: Verified
  Yair Zaslavsky: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18065
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I000bbb3cf5a6d1d636c49247e85858b02b2f358a
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list