Change in ovirt-hosted-engine-ha[master]: lib: fix acceptance of keyword arguments for vdsm api

gpadgett at redhat.com gpadgett at redhat.com
Mon Oct 14 22:01:25 UTC 2013


Greg Padgett has submitted this change and it was merged.

Change subject: lib: fix acceptance of keyword arguments for vdsm api
......................................................................


lib: fix acceptance of keyword arguments for vdsm api

A prior refactoring broke keyword argument usage in calls to the
run_vds_client_cmd() method.  This fix allows for both argument lists
and keyword arguments, and automatically converts the keyword arguments
to a dict that is accepted by the vdsm api.  Callers should be careful
to use the proper parameter form as required by the vdsm api.

Change-Id: I9931d6c87b0798152bf344ddd8b9328ce01565a8
Bug-Url: https://bugzilla.redhat.com/1015721
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
---
M ovirt_hosted_engine_ha/lib/vds_client.py
1 file changed, 8 insertions(+), 3 deletions(-)

Approvals:
  Greg Padgett: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19872
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9931d6c87b0798152bf344ddd8b9328ce01565a8
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list