Change in ovirt-engine[ovirt-engine-3.3]: engine: Prevent empty MAC Address range

iheim at redhat.com iheim at redhat.com
Tue Oct 22 05:41:40 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: engine: Prevent empty MAC Address range
......................................................................


engine: Prevent empty MAC Address range

The patch prevents a user from entering a mac address
range which might result in an empty pool, for example
a range which contains multicast mac addresses only.

Change-Id: I24113379e8fbbc15a63bdb1be4e6c719d7cb764f
Bug-Url: https://bugzilla.redhat.com/1011912
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/MacPoolManager.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/MacAddressRangeUtils.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java
M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelperTest.java
4 files changed, 73 insertions(+), 73 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20177
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24113379e8fbbc15a63bdb1be4e6c719d7cb764f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list