Change in ovirt-engine[ovirt-engine-3.3]: core: empty quota causes FK violation

iheim at redhat.com iheim at redhat.com
Wed Oct 30 11:27:40 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: core: empty quota causes FK violation
......................................................................


core: empty quota causes FK violation

When creating a disk in Foreman, the disk object is sent via
REST with empty string in id attribute:
<quota id=""/>

REST creates an empty UUID (000...) out of empty string, and causes
FK violation, since there is no quota with that id.

This patch fixes it by ignoring empty quota for adding disk.

Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b
Bug-Url: https://bugzilla.redhat.com/1022942
Signed-off-by: Gilad Chaplik <gchaplik at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20499
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic488486edc7c5602d24e804c9a89aeccc98fc32b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list