Change in ovirt-engine[master]: core: RemoveStorageDomainCommandTest: annotations

amureini at redhat.com amureini at redhat.com
Wed Oct 30 16:32:18 UTC 2013


Allon Mureinik has submitted this change and it was merged.

Change subject: core: RemoveStorageDomainCommandTest: annotations
......................................................................


core: RemoveStorageDomainCommandTest: annotations

Use the modern @Mock annotation instead of explicitly calling
Mockito.mock.
The resulting class is easier to understand since the mocking does not
interrupt the flow of reading setUp().

Change-Id: I3f2c9d3ccf1810f0532b2200acda27679fee158d
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommandTest.java
1 file changed, 7 insertions(+), 4 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/20680
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f2c9d3ccf1810f0532b2200acda27679fee158d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list