Change in ovirt-engine[master]: core: fix possible NPE in internal migration

ofrenkel at redhat.com ofrenkel at redhat.com
Sun Sep 1 14:34:04 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: fix possible NPE in internal migration
......................................................................


core: fix possible NPE in internal migration

The check for migration support uses the VM and it was executed before
the VM was validated (that it is not null). Thus, this patch changes the
order of the checks, so that the migration support check will be
executed after the checks in MigrateVmCommand are executed.

Change-Id: I1c287d989e62daa43e834d9f9657dac9820764a3
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java
1 file changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18586
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c287d989e62daa43e834d9f9657dac9820764a3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list