Change in otopi[master]: core: filetransaction: Always add a newline

Alon Bar-Lev alonbl at redhat.com
Sun Sep 1 18:58:26 UTC 2013


Alon Bar-Lev has submitted this change and it was merged.

Change subject: core: filetransaction: Always add a newline
......................................................................


core: filetransaction: Always add a newline

Always add newline when the content is a non-empty list or tuple.
Without this change, files that have an empty last line, and are edited
by reading them with read().splitlines(), changing some lines, and then
writing them with filetransaction, loose their empty last line.

Change-Id: I97f0feef1c003250c9f7453245f68398c64051cd
Signed-off-by: Yedidyah Bar David <didi at redhat.com>
---
M src/otopi/filetransaction.py
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Alon Bar-Lev: Looks good to me, approved
  Yedidyah Bar David: Verified



-- 
To view, visit http://gerrit.ovirt.org/18690
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I97f0feef1c003250c9f7453245f68398c64051cd
Gerrit-PatchSet: 3
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>



More information about the Engine-commits mailing list