Change in ovirt-engine[master]: frontend: MaxVmNameLength(Non)Windows ignored

tjelinek at redhat.com tjelinek at redhat.com
Thu Sep 12 07:12:54 UTC 2013


Tomas Jelinek has submitted this change and it was merged.

Change subject: frontend: MaxVmNameLength(Non)Windows ignored
......................................................................


frontend: MaxVmNameLength(Non)Windows ignored

It has already been fixed but not completly correctly. There is
still a chance that the static variables will be inited sooner than
the cache from which the values are taken.

Fixed by moving the corresponding logic to AsyncDataProvider which
is anyway a better place for it and postpone the calling of it until
it is really needed so the cache will be inited for sure (otherwise
it would be not possible to reach to the code which uses it).

Change-Id: I9a1ac29aadc731f6fe4a0e62db7e78a5160ededa
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/VmBackupModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/PoolNameLengthValidation.java
4 files changed, 16 insertions(+), 18 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/18989
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9a1ac29aadc731f6fe4a0e62db7e78a5160ededa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list