Change in ovirt-hosted-engine-setup[master]: vdsm: use devices instead of drives in vm.conf

sbonazzo at redhat.com sbonazzo at redhat.com
Thu Sep 19 15:09:06 UTC 2013


Sandro Bonazzola has submitted this change and it was merged.

Change subject: vdsm: use devices instead of drives in vm.conf
......................................................................


vdsm: use devices instead of drives in vm.conf

Previously the setup used the keywords drives, cdrom,
nicModel, bridge and macAddr for configuring the VM
devices.
Such keywords seem to be obsolete and lead to having
the share:exclusive option not working correctly on drives.
Now it uses the keyword devices for configuring all the devices
and drives in order to have share:exclusive support.

Change-Id: Idbe61b2ef899320f304cd30b5b365e2a523acd49
Bug-Url: https://bugzilla.redhat.com/1008391
Signed-off-by: Sandro Bonazzola <sbonazzo at redhat.com>
---
M src/ovirt_hosted_engine_setup/constants.py
M src/plugins/ovirt-hosted-engine-setup/vm/configurevm.py
M templates/vm.conf.in
3 files changed, 34 insertions(+), 11 deletions(-)

Approvals:
  Sandro Bonazzola: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19289
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idbe61b2ef899320f304cd30b5b365e2a523acd49
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Leonid Natapov <leonidnatapov at gmail.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list