Change in mom[master]: mom: Fix KeyError exception while qemu-guest-agent error han...

agl at us.ibm.com agl at us.ibm.com
Thu Sep 19 16:04:09 UTC 2013


Adam Litke has submitted this change and it was merged.

Change subject: mom: Fix KeyError exception while qemu-guest-agent error handling
......................................................................


mom: Fix KeyError exception while qemu-guest-agent error handling

Current version of qemu-guest-agent reports error messages in the format:
    {"error":{"class":"GenericError","desc":"..."}}

GuestQemuAgent tries to get "data" member on the error response, and results
in KeyError exception as the response doesn't have it. Catch the exception,
and also reference "desc" member for the error message.

Change-Id: Ibfb84eac189716513f686d5b035056a0c1bc36d3
Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama at hds.com>
Reviewed-on: http://gerrit.ovirt.org/18887
Reviewed-by: Adam Litke <agl at us.ibm.com>
Tested-by: Adam Litke <agl at us.ibm.com>
---
M mom/Collectors/GuestQemuAgent.py
1 file changed, 12 insertions(+), 3 deletions(-)

Approvals:
  Adam Litke: Verified; Looks good to me, approved
  Tomoki Sekiyama: Verified



-- 
To view, visit http://gerrit.ovirt.org/18887
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfb84eac189716513f686d5b035056a0c1bc36d3
Gerrit-PatchSet: 2
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Tomoki Sekiyama <tomoki.sekiyama at hds.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Tomoki Sekiyama <tomoki.sekiyama at hds.com>



More information about the Engine-commits mailing list