Change in ovirt-engine[ovirt-engine-3.3]: webadmin: Refactor RoleTreeView

iheim at redhat.com iheim at redhat.com
Sun Sep 29 10:05:12 UTC 2013


Itamar Heim has submitted this change and it was merged.

Change subject: webadmin: Refactor RoleTreeView
......................................................................


webadmin: Refactor RoleTreeView

RoleTreeView had too long and complicated method
with too many indentation levels. The patch reduces
the complexity and allows new entities to be added
more easily to the Action Groups tree.

Change-Id: I82431f3e96be13d3815e9e89130f4cd674394bc8
Related-To: https://bugzilla.redhat.com/1002483
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleTreeView.java
1 file changed, 207 insertions(+), 341 deletions(-)

Approvals:
  Itamar Heim: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19525
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82431f3e96be13d3815e9e89130f4cd674394bc8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list