Change in ovirt-engine[master]: core: fix unchecked cast

ofrenkel at redhat.com ofrenkel at redhat.com
Mon Sep 30 08:21:24 UTC 2013


Omer Frenkel has submitted this change and it was merged.

Change subject: core: fix unchecked cast
......................................................................


core: fix unchecked cast

Coverity scan detected unchecked cast from VdcActionParametersBase to
ImagesActionsParametersBase in CreateAllSnapshotsFromVmCommand class.
This patch solved it by verifing with 'instanceof' check that the cast
is safe.

Change-Id: I7da9f46ae0742efb376ce558be48b9357e906e85
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Omer Frenkel: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19646
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7da9f46ae0742efb376ce558be48b9357e906e85
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list