Change in ovirt-engine[master]: core: fix sound device check when adding devices from ovf (#...

rgolan at redhat.com rgolan at redhat.com
Mon Sep 30 11:08:44 UTC 2013


Roy Golan has submitted this change and it was merged.

Change subject: core: fix sound device check when adding devices from ovf (#1004066)
......................................................................


core: fix sound device check when adding devices from ovf (#1004066)

When creating vm from ovf, there is a check to add sound device to the
vm if it doesn't exist and needed.
the existence check was wrong as it used 'device' compared with 'type'.

this patch fix the check to use the correct fields (type).

Change-Id: I117c18f95db1ed672f6d0a8c4ff5c003d3fb6d4a
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
Bug-Url: https://bugzilla.redhat.com/1004066
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
2 files changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Roy Golan: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/19561
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I117c18f95db1ed672f6d0a8c4ff5c003d3fb6d4a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list