Change in ovirt-engine[master]: findbugs: Clean up ST warnings

emesika at redhat.com emesika at redhat.com
Tue Apr 8 09:17:12 UTC 2014


Eli Mesika has submitted this change and it was merged.

Change subject: findbugs: Clean up ST warnings
......................................................................


findbugs: Clean up ST warnings

Removed all-out ST category suppression and replaced it with narrow,
targeted suppressions, so that future instance methods updating static
variables will be caught by FindBugs.

Change-Id: I158d22e2c7e5f1ccedb6782b3288473f33e47a3f
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/exclude-filters.xml
M exclude-filters-general.xml
M frontend/webadmin/modules/gwt-common/exclude-filters.xml
M frontend/webadmin/modules/uicommonweb/exclude-filters.xml
M frontend/webadmin/modules/userportal-gwtp/exclude-filters.xml
M frontend/webadmin/modules/webadmin/exclude-filters.xml
6 files changed, 73 insertions(+), 10 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Verified



-- 
To view, visit http://gerrit.ovirt.org/26474
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I158d22e2c7e5f1ccedb6782b3288473f33e47a3f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Alissa Bonas <abonas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org



More information about the Engine-commits mailing list