Change in ovirt-engine[ovirt-engine-3.4]: host-deploy: flush both stdout, stderr at ssh execute

oourfali at redhat.com oourfali at redhat.com
Thu Apr 10 11:12:42 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: host-deploy: flush both stdout, stderr at ssh execute
......................................................................


host-deploy: flush both stdout, stderr at ssh execute

although until unclear why it is needed.

1. flush before java attempt to close using try-with-resources.

2. flush also stderr.

3. perform at one location.

Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1084911
Change-Id: I14424723f2ef6abff6f3abdc1072e5ac621d4e67
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java
2 files changed, 10 insertions(+), 12 deletions(-)

Approvals:
  Alon Bar-Lev: Verified
  Oved Ourfali: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/26586
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I14424723f2ef6abff6f3abdc1072e5ac621d4e67
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: David Caro <dcaroest at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list