Change in ovirt-engine[ovirt-engine-3.4]: webadmin: Block adding of mixed domain to a pool if not supp...

oourfali at redhat.com oourfali at redhat.com
Tue Apr 29 04:49:42 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: webadmin: Block adding of mixed domain to a pool if not supported by version
......................................................................


webadmin: Block adding of mixed domain to a pool if not supported by version

When adding a new storage domain via webadmin where the compatibility
version does not support mixed storage types we might encounter a situation
where the domain is created and the attach to the data center is failing
and the setup is left with an unattached domain, to prevent that we now
disallow addition from a storage type (block/file) to a data center that
does not support mixed types and already have attached domains of another
storage type (e.g. adding an iSCSI storage domain to a v3.3 data center
V3.3 with an NFS domain attached will be prohibited)

Change-Id: Ib31884e6fd5a7868e9bb21c9566bcd2e445de52a
Bug-Url: https://bugzilla.redhat.com/1085395
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NewEditStorageModelBehavior.java
3 files changed, 74 insertions(+), 25 deletions(-)

Approvals:
  Tal Nisan: Verified
  Daniel Erez: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/27139
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib31884e6fd5a7868e9bb21c9566bcd2e445de52a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list