Change in ovirt-engine[master]: core: Refactor FenceVdsActionParameters

emesika at redhat.com emesika at redhat.com
Wed Aug 6 14:41:52 UTC 2014


Eli Mesika has submitted this change and it was merged.

Change subject: core: Refactor FenceVdsActionParameters
......................................................................


core: Refactor FenceVdsActionParameters

Refactors FenceVdsActionParameters:
 1) Moves instance attributes before methods
 2) Remove '_' from attribute names
 3) Use constructor chaining
 4) Set default values of instance variables in constructor

Change-Id: I43bc8d5336633cf0f259d08803d2e902be006791
Bug-Url: https://bugzilla.redhat.com/1090799
Signed-off-by: Martin Perina <mperina at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/FenceVdsActionParameters.java
1 file changed, 11 insertions(+), 11 deletions(-)

Approvals:
  Martin Peřina: Verified
  Eli Mesika: Looks good to me, approved
  Oved Ourfali: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/30582
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I43bc8d5336633cf0f259d08803d2e902be006791
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list