Change in ovirt-engine[ovirt-engine-3.5]: core: fix edit of sound card for running vm

tnisan at redhat.com tnisan at redhat.com
Mon Aug 11 11:44:08 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: fix edit of sound card for running vm
......................................................................


core: fix edit of sound card for running vm

Currently, when updating the sound card setting for running vm,
the query that checks if sound card exists is wrong, because sound card
can have multiple types of devices (ac97,ich6)

Added a code that use the "UNKNOWN" device type,
to mark the mechanism to use only the general device type (sound)
without the specific type.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1128416
Change-Id: If2ff54c3d0929ddf04f39bb42e61e185005d9655
Signed-off-by: Omer Frenkel <ofrenkel at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmManagementParametersBase.java
3 files changed, 16 insertions(+), 5 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Omer Frenkel: Verified



-- 
To view, visit http://gerrit.ovirt.org/31207
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If2ff54c3d0929ddf04f39bb42e61e185005d9655
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list