Change in ovirt-engine[ovirt-engine-3.5]: core: fix incorrect value of migrating_to_vds

tnisan at redhat.com tnisan at redhat.com
Thu Aug 21 09:15:49 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: fix incorrect value of migrating_to_vds
......................................................................


core: fix incorrect value of migrating_to_vds

Since we retried to switch host to maintenance as part of the monitoring
thread but before the updated data from the monitoring was saved, the
migrating_to_vds could have been overridden and set back to its
previous value.

This bug caused NPE in VURTI#handOver method sometimes and sometimes it
produced a VM which is not migrating with some wrong value in its
migrating_to_vds field.

The solution is to retry to switch host to maintenance in the
after-refresh-treatment part of the monitoring.

Change-Id: I423d573ae5251d3058bdfb778a2b486ac5ea0090
Bug-Url: https://bugzilla.redhat.com/1112359
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
1 file changed, 11 insertions(+), 4 deletions(-)

Approvals:
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/31721
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I423d573ae5251d3058bdfb778a2b486ac5ea0090
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list