Change in ovirt-engine[master]: Checking isProvisioned instead of the redundant entity isDis...

oourfali at redhat.com oourfali at redhat.com
Sun Aug 31 11:04:34 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: Checking isProvisioned instead of the redundant entity isDiscovered
......................................................................


Checking isProvisioned instead of the redundant entity isDiscovered

isDiscovered was a mistake which checked only the textbox entity. The
entity is filled with value when there are discovered host, so that
check was wrong.

This patch checks if the flow is for discovered or provisioning based on
the isProvisioned entity, which is set when changing the radio buttons.

Change-Id: Iee2f17c2aee18a1a619551a491af56075ae8cdc5
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1133540
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
2 files changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Oved Ourfali: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/32021
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iee2f17c2aee18a1a619551a491af56075ae8cdc5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list