Change in ovirt-engine[ovirt-engine-3.5]: webadmin: isRemoveCommandAvailable() - removal of unneeded b...

tnisan at redhat.com tnisan at redhat.com
Sun Aug 31 14:11:57 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: webadmin: isRemoveCommandAvailable() - removal of unneeded booleans
......................................................................


webadmin: isRemoveCommandAvailable() - removal of unneeded booleans

isRemoveCommandAvailable() is storing the checks results into booleans
and checks them all at each iteration.
The booleans can be replaced with comments and we can return immediately
when the result is known.

Change-Id: I808275fb826e2d4fd154e87aa9730f4c57b53002
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1131845
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
1 file changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Liron Aravot: Verified



-- 
To view, visit http://gerrit.ovirt.org/32187
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I808275fb826e2d4fd154e87aa9730f4c57b53002
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list