Change in ovirt-engine[master]: core: handling of possible race when deactivating domain

laravot at redhat.com laravot at redhat.com
Wed Dec 3 08:31:21 UTC 2014


Liron Aravot has submitted this change and it was merged.

Change subject: core: handling of possible race when deactivating domain
......................................................................


core: handling of possible race when deactivating domain

When deactivating the last  master domain a new thread is started to make sure that
the domain is deactivated only after the tasks are cleared.
In case of engine crash during that time the domain may remain in status
LOCKED, because nothing will restart the thread on the engine start (as
the tasks were cleared).
The infrastructure that we currently have to handle that case is the
compensation context, in this patch i create a compensation context that
will assure that the domain will return to the appropiate status in case
of an engine crash.

Change-Id: If4e482a2a13741e8b4509851d9d8e4645d8b81e6
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ProcessOvfUpdateForStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageDomainCommandBase.java
4 files changed, 43 insertions(+), 13 deletions(-)

Approvals:
  Liron Aravot: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35215
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4e482a2a13741e8b4509851d9d8e4645d8b81e6
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list