Change in ovirt-engine[master]: core: hotfix daotests in VmStaticDAOTest

ahadas at redhat.com ahadas at redhat.com
Mon Dec 8 08:34:36 UTC 2014


Arik Hadas has submitted this change and it was merged.

Change subject: core: hotfix daotests in VmStaticDAOTest
......................................................................


core: hotfix daotests in VmStaticDAOTest

testGetOrderedVmGuidsForRunMultipleActionsByMigrationSupport which tested db
logic for ordered VmGuids retrieval (with respect to MigrationSupport
attribute) was failing because the number of tested vms was 4, but
MigrationSupport has only 3 possible values. Therefore there were 2 VMs that
were equal with respect to this ordering.

Hot-fixed by restricting the number of test VMs to 3.

Change-Id: I0ea611effabb69a693194a6a0639f2d3c17d08e5
Signed-off-by: Frantisek Kobzik <fkobzik at redhat.com>
---
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Frank Kobzik: Verified
  Arik Hadas: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ea611effabb69a693194a6a0639f2d3c17d08e5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list