Change in ovirt-engine[master]: webadmin: Start/stop progress on async operations

lvernia at redhat.com lvernia at redhat.com
Sun Dec 14 15:11:04 UTC 2014


Lior Vernia has submitted this change and it was merged.

Change subject: webadmin: Start/stop progress on async operations
......................................................................


webadmin: Start/stop progress on async operations

Implemented some infrastructure to automatically trigger loading
animation whenever an async operation is invoked, and cancel the
animation whenever the operations returns.

This only happens if upon initialization of the operation, the source
model is "properly" passed. For a single query, the model should be
passed as the target of its AsyncQuery callback. Otherwise (multiple
queries, single/multiple actions), the model should be passed as the
"state" argument.

Also, this only happens in case progress wasn't manually set; if it
had been, then this would override the automatic infrastructure
altogether.

Change-Id: I24ed80a5453668b37f488e0226f7bdfbf36e503d
Bug-Url: https://bugzilla.redhat.com/1167327
Signed-off-by: Lior Vernia <lvernia at redhat.com>
---
M frontend/webadmin/modules/frontend/exclude-filters.xml
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java
A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/AsyncOperationComplete.java
A frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/AsyncOperationStarted.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendActionTest.java
M frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/FrontendTest.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
7 files changed, 147 insertions(+), 16 deletions(-)

Approvals:
  Lior Vernia: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35964
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I24ed80a5453668b37f488e0226f7bdfbf36e503d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list