Change in ovirt-engine[master]: aaa: two providers produce the same "domain id"

oourfali at redhat.com oourfali at redhat.com
Tue Dec 16 15:37:11 UTC 2014


Oved Ourfali has submitted this change and it was merged.

Change subject: aaa: two providers produce the same "domain id"
......................................................................


aaa: two providers produce the same "domain id"

This may occur if two authz names have the same prefix that gets
converted to the same Guid.
This happens as the Guid ctor that receives an array of bytes needs
only the first 16 bytes to consturct a guid and ignores the rest.
The fix suggest an id that is based on base64 encoding of the entire string.

Change-Id: Ieddb2c31645d7276652db17df190bc4f2cfdaacb
Bug-Url: https://bugzilla.redhat.com/1172187
Topic: AAA
Signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainGroupsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainUsersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendDomainsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResourceTest.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/GroupMapper.java
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/UserMapper.java
8 files changed, 46 insertions(+), 38 deletions(-)

Approvals:
  Yair Zaslavsky: Verified
  Oved Ourfali: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/36092
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieddb2c31645d7276652db17df190bc4f2cfdaacb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at gmail.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list