Change in ovirt-engine[master]: core: preventing NPE on StorageServerConnectionCommandBase

[laravot at redhat.com]

Liron Aravot has submitted this change and it was merged.

Change subject: core: preventing NPE on StorageServerConnectionCommandBase
......................................................................


core: preventing NPE on StorageServerConnectionCommandBase

Currently we allow to added FCP connections although they aren't
supported in oVirt - this has been changed by change 2f7c846 as was
required because of how we store the connections password in the DB.
After this change in case of added FCP connection, NPE will occur.
This patch fixes that by restoring the previous state, we may block
adding FCP connections regardless (as having them isn't supported/used
by the engine).

Change-Id: I6662695ba876f9e3f5a22c3251895049bf9eaedc
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageServerConnectionCommandBase.java
2 files changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Allon Mureinik: Looks good to me, approved
  Liron Aravot: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/36433
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6662695ba876f9e3f5a22c3251895049bf9eaedc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: automation at ovirt.org