Change in ovirt-engine[master]: core: refactor OvfVmReader#readHardwareSection

ofrenkel at redhat.com ofrenkel at redhat.com
Tue Feb 4 11:35:26 UTC 2014


Omer Frenkel has submitted this change and it was merged.

Change subject: core: refactor OvfVmReader#readHardwareSection
......................................................................


core: refactor OvfVmReader#readHardwareSection

The method OvfVmReader#readHardwareSection was too long. By extracting
the handling of each hardware type into a separate method and using
the relatively new capability in Java of switch-case statement on
String, this patch simplify that method.

Change-Id: I403489679eb97359842a3662278b7312a81911fd
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java
1 file changed, 131 insertions(+), 85 deletions(-)

Approvals:
  Omer Frenkel: Looks good to me, approved
  Arik Hadas: Verified



-- 
To view, visit http://gerrit.ovirt.org/23978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I403489679eb97359842a3662278b7312a81911fd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list