Change in ovirt-engine[master]: core: Fix faulty CDA in AddVmAndCloneImageCommand

amureini at redhat.com amureini at redhat.com
Tue Feb 4 20:03:39 UTC 2014


Allon Mureinik has submitted this change and it was merged.

Change subject: core: Fix faulty CDA in AddVmAndCloneImageCommand
......................................................................


core: Fix faulty CDA in AddVmAndCloneImageCommand

In case super returned true, CDA returned true with no regard to what
happens in the for loop. This patch aims to implement to author's
original intention while using early return.

Change-Id: Ib4e63bf719a9bc98145a6401b05ed47005655486
Signed-off-by: Vered Volansky <vvolansk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
1 file changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Looks good to me, approved
  Allon Mureinik: Looks good to me, approved
  Vered Volansky: Verified



-- 
To view, visit http://gerrit.ovirt.org/24051
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4e63bf719a9bc98145a6401b05ed47005655486
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list