Change in ovirt-engine[master]: userportal, webadmin: fix 404 regression for help files

awels at redhat.com awels at redhat.com
Mon Feb 10 15:51:31 UTC 2014


Alexander Wels has submitted this change and it was merged.

Change subject: userportal, webadmin: fix 404 regression for help files
......................................................................


userportal, webadmin: fix 404 regression for help files

Patch http://gerrit.ovirt.org/#/c/21052/ introduced a regression where if no
help mapping json files are found, a 404 is served to the UI and logged.

This fixes that by sending back an empty JSON string.

There was also a path mapping bug in patch http://gerrit.ovirt.org/#/c/21052/
and this fixes that as well.

Change-Id: I219e986ac45e7a05801bd9b519a006a429e5f82f
Signed-off-by: Greg Sheremeta <gshereme at redhat.com>
---
M backend/manager/modules/docs/src/main/java/org/ovirt/engine/docs/utils/servlet/HelpTagJsonServlet.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java
4 files changed, 18 insertions(+), 9 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, but someone else must approve
  Greg Sheremeta: Verified
  Vojtech Szocs: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24212
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I219e986ac45e7a05801bd9b519a006a429e5f82f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list