Change in ovirt-engine[master]: core, webadmin: Warn about incompatible upgrade

amureini at redhat.com amureini at redhat.com
Wed Feb 12 11:37:19 UTC 2014


Allon Mureinik has submitted this change and it was merged.

Change subject: core, webadmin: Warn about incompatible upgrade
......................................................................


core, webadmin: Warn about incompatible upgrade

When upgrading a DC, a warning is issued if this upgrade would cause
upgrading the domains' storage format.

This patch improves that message by adding information that this upgrade
will cause the domains to be unusable with products of version XYZ.

The patch includes:
1. A method in VersionStorageFormatUtil to retrieve the earliest
   supported version of a given format.
2. A unit test for said method
3. Migrating the message from UIConstants to UIMessages, and adding a
   version parameter.
4. The call in DataCenterListModel for said message.

Change-Id: I3fa7345caad8603c03fb042dec2cebf6fdc03f44
Bug-Url: https://bugzilla.redhat.com/957939
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtil.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/VersionStorageFormatUtilTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIMessages.java
5 files changed, 44 insertions(+), 7 deletions(-)

Approvals:
  Allon Mureinik: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24028
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3fa7345caad8603c03fb042dec2cebf6fdc03f44
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Cheryn Tan <cheryntan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list