Change in ovirt-engine[master]: core: Make sure disk alias will never be null

tnisan at redhat.com tnisan at redhat.com
Wed Feb 12 15:33:23 UTC 2014


Tal Nisan has submitted this change and it was merged.

Change subject: core: Make sure disk alias will never be null
......................................................................


core: Make sure disk alias will never be null

In case of running a VM with disks imported from version lower than V3.0
OVFs or from P2V/V2V, the disk aliases created can be null, when the
CreateVmVdsCommand is running it sorts the disks by the aliases yet the
comparator does not check if one of the aliases is null and fails on an
NPE, this patch fixes this issue by making sure that the disk alias
property will never be null

Change-Id: I110f40b121a0bff8117888399fd5b798a9f19c10
Signed-off-by: Tal Nisan <tnisan at redhat.com>
Bug-url: https://bugzilla.redhat.com/1059403
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BaseDisk.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tal Nisan: Verified
  Liron Ar: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24269
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I110f40b121a0bff8117888399fd5b798a9f19c10
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list