Change in ovirt-engine[ovirt-engine-3.4]: webadmin, userportal: Small ScrollableTabBar improvements

iheim at redhat.com iheim at redhat.com
Mon Feb 17 13:59:23 UTC 2014


Itamar Heim has submitted this change and it was merged.

Change subject: webadmin,userportal: Small ScrollableTabBar improvements
......................................................................


webadmin,userportal: Small ScrollableTabBar improvements

1. ScrollableTabBarView:
   - removed "implements HasLoadHandlers"
   - removed fireEvent + addLoadHandler methods
   - the "+1 width adjustment" comment moved to
     appropriate location

2. ModelBoundTab:
   - added setAccessible override that fires
     TabAccessibleChangeEvent whenever tab's
     accessibility changes

Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d
Signed-off-by: Vojtech Szocs <vszocs at redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ScrollableTabBarView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/tab/ModelBoundTab.java
2 files changed, 15 insertions(+), 19 deletions(-)

Approvals:
  Alexander Wels: Looks good to me, approved
  Vojtech Szocs: Verified



-- 
To view, visit http://gerrit.ovirt.org/24478
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7ffdb2827067b35320fd43d37db80479df6605d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: Alexander Wels <awels at redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen at redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list