Change in ovirt-engine[master]: tools: notifier: Notification properties changes.

emesika at redhat.com emesika at redhat.com
Tue Feb 18 19:40:02 UTC 2014


Eli Mesika has submitted this change and it was merged.

Change subject: tools: notifier: Notification properties changes.
......................................................................


tools: notifier: Notification properties changes.

Before this change validation was done both in
NotificationService.initConfigurationProperties and in NotificationProperties
itself. all moved to  NotificationProperties.

The properties themself are not read from the notification service
to be instance variables inside the notifier but are read each time
they are needed.

Change-Id: I5753ba2cad2de90a7f2d14bd4675edc1dd35045e
Signed-off-by: Mooli Tayer <mtayer at redhat.com>
---
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java
M backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
2 files changed, 92 insertions(+), 118 deletions(-)

Approvals:
  Alon Bar-Lev: Looks good to me, but someone else must approve
  Eli Mesika: Verified; Looks good to me, approved
  mooli tayer: Verified; Looks good to me, but someone else must approve
  Yair Zaslavsky: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23080
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5753ba2cad2de90a7f2d14bd4675edc1dd35045e
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list