Change in ovirt-engine[master]: core: AddDiskCommand - added disk can never be a disk snapshot

laravot at redhat.com laravot at redhat.com
Wed Feb 19 07:55:53 UTC 2014


Liron Ar has submitted this change and it was merged.

Change subject: core: AddDiskCommand - added disk can never be a disk snapshot
......................................................................


core: AddDiskCommand - added disk can never be a disk snapshot

When adding a disk the added disk can never be a disk snapshot,
Currently when adding DiskImages the disk's Image object is "active"
member has a default value of false, which leads to wrongly treat that
disk as a disk snapshot through validations rather than a regular added
disk.

Change-Id: I13c3c819a25bd33e5443d82728423c0de7087326
Signed-off-by: Liron Aravot <laravot at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
2 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Daniel Erez: Looks good to me, but someone else must approve
  Allon Mureinik: Looks good to me, approved
  Liron Ar: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24395
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I13c3c819a25bd33e5443d82728423c0de7087326
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list