Change in ovirt-engine[ovirt-engine-3.4]: core: Change existing disk validation CDA message in case of...

iheim at redhat.com iheim at redhat.com
Wed Feb 19 19:52:26 UTC 2014


Itamar Heim has submitted this change and it was merged.

Change subject: core: Change existing disk validation CDA message in case of null disk alias
......................................................................


core: Change existing disk validation CDA message in case of null disk alias

When try to import a VM which one or more of it's disks already exist on
the system there's a CDA message containing the disk aliases of the existing
disks, the aliases are taken from the disks in the export domian but in case
the alias is null (mainly in backups of versions <V3.0, P2V, V2V etc..) the
alias was displayed as a blank string, the CDA message was change and in case
the alias is null the alias will be taken from the disk in the system

Change-Id: I07b794b0fe9bdc5c83a62a74b82653ce209327b7
Signed-off-by: Tal Nisan <tnisan at redhat.com>
Bug-Url: https://bugzilla.redhat.com/928864
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/DiskImagesValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/DiskImagesValidatorTest.java
2 files changed, 32 insertions(+), 6 deletions(-)

Approvals:
  Tal Nisan: Verified
  Allon Mureinik: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I07b794b0fe9bdc5c83a62a74b82653ce209327b7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list