Change in ovirt-engine[master]: core: remove redundant transaction on run vm

ahadas at redhat.com ahadas at redhat.com
Tue Feb 18 14:51:09 UTC 2014


Arik Hadas has submitted this change and it was merged.

Change subject: core: remove redundant transaction on run vm
......................................................................


core: remove redundant transaction on run vm

Saving the VM dynamic information that we get back from VDSM after
calling VDSM to create a VM was used to be executed in transaction
because we used to update information related to the VDS in the DB
and we wanted it to be atomically.

Now that we don't update anything else in the DB besides the dynamic
information of the VM, doing the update in transaction with Required
scope is redundant and we can drop the transaction.

Change-Id: I9819a9defe421deab3badf1e4e1e62e7e3e3e92f
Signed-off-by: Arik Hadas <ahadas at redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java
1 file changed, 6 insertions(+), 16 deletions(-)

Approvals:
  Roy Golan: Looks good to me, approved
  Arik Hadas: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/24551
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9819a9defe421deab3badf1e4e1e62e7e3e3e92f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list